-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Add QVGA sensor mode for usb2 support on L515 #6668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QVGA sensor mode for usb2 support on L515 #6668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API-change PR should be retrofitted the relevant wrappers, e.g. Python, C#, Java.
You can look up for SENSOR_MODE_VGA under /wrappers dir to generate the candidates list.
include/librealsense2/h/rs_option.h
Outdated
@@ -148,6 +148,7 @@ extern "C" { | |||
/** \brief For setting the camera_mode option */ | |||
typedef enum rs2_sensor_mode | |||
{ | |||
RS2_SENSOR_MODE_QVGA, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks the existing API.
Should be appended before COUNT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
src/l500/l500-options.cpp
Outdated
@@ -94,7 +94,7 @@ namespace librealsense | |||
} | |||
else | |||
{ | |||
auto resolution_option = std::make_shared<float_option_with_description<rs2_sensor_mode>>(option_range{ RS2_SENSOR_MODE_VGA,RS2_SENSOR_MODE_XGA,1, RS2_SENSOR_MODE_XGA }, "Notify the sensor about the intended streaming mode. Required for preset "); | |||
auto resolution_option = std::make_shared<float_option_with_description<rs2_sensor_mode>>(option_range{ RS2_SENSOR_MODE_QVGA,RS2_SENSOR_MODE_XGA,1, RS2_SENSOR_MODE_XGA }, "Notify the sensor about the intended streaming mode. Required for preset "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be reordered accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
9124374
to
10e402a
Compare
Support QVGA (240x320) resolution on L515 device
Tracked on Jira [RS5-7992]