Skip to content

Add QVGA sensor mode for usb2 support on L515 #6668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Jun 22, 2020

Support QVGA (240x320) resolution on L515 device

Tracked on Jira [RS5-7992]

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API-change PR should be retrofitted the relevant wrappers, e.g. Python, C#, Java.
You can look up for SENSOR_MODE_VGA under /wrappers dir to generate the candidates list.

@@ -148,6 +148,7 @@ extern "C" {
/** \brief For setting the camera_mode option */
typedef enum rs2_sensor_mode
{
RS2_SENSOR_MODE_QVGA,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks the existing API.
Should be appended before COUNT

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -94,7 +94,7 @@ namespace librealsense
}
else
{
auto resolution_option = std::make_shared<float_option_with_description<rs2_sensor_mode>>(option_range{ RS2_SENSOR_MODE_VGA,RS2_SENSOR_MODE_XGA,1, RS2_SENSOR_MODE_XGA }, "Notify the sensor about the intended streaming mode. Required for preset ");
auto resolution_option = std::make_shared<float_option_with_description<rs2_sensor_mode>>(option_range{ RS2_SENSOR_MODE_QVGA,RS2_SENSOR_MODE_XGA,1, RS2_SENSOR_MODE_XGA }, "Notify the sensor about the intended streaming mode. Required for preset ");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be reordered accordingly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Nir-Az Nir-Az force-pushed the support_QVGA_on_L515 branch from 9124374 to 10e402a Compare June 23, 2020 08:17
@Nir-Az Nir-Az requested a review from ev-mp June 23, 2020 08:18
@ev-mp ev-mp merged commit 547f8dc into IntelRealSense:development Jun 23, 2020
@Nir-Az Nir-Az deleted the support_QVGA_on_L515 branch September 1, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants