Blocking AE control in D457 #13893
Merged
Blocking AE control in D457 #13893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Mar 30, 2025
OhadMeir
reviewed
Mar 30, 2025
| @@ -553,7 +553,8 @@ inline void draw_advanced_mode_controls(rs400::advanced_mode& advanced, | |||
| ImGui::TreePop(); | |||
| } | |||
|
|
|||
| if (ImGui::TreeNode("AE Control")) | |||
| //AE setpoint is blocked in D457 | |||
There was a problem hiding this comment.
Is relevant to D457 or all MIPI devices? better to remove comment
OhadMeir
reviewed
Mar 30, 2025
common/realsense-ui-advanced-mode.h
Outdated
| @@ -203,7 +203,7 @@ struct advanced_mode_control | |||
| }; | |||
|
|
|||
| inline void draw_advanced_mode_controls(rs400::advanced_mode& advanced, | |||
| advanced_mode_control& amc, bool& get_curr_advanced_controls, bool& was_set, std::string& error_message) | |||
| advanced_mode_control& amc, bool& get_curr_advanced_controls, bool& was_set, std::string& error_message, bool mipi_device=false) | |||
There was a problem hiding this comment.
I think it is better to pass device name or connection type and let this function implement the logic of checking it rather then pass a flag.
64ec11e to
f05ea38
Compare
Nir-Az
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by RSDSO-19752