Skip to content

Remove Xenial patches and scripts #13876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

AviaAv
Copy link
Contributor

@AviaAv AviaAv commented Mar 23, 2025

Tracked on: [LRS-1145]

@AviaAv AviaAv requested a review from Nir-Az March 23, 2025 11:25
@@ -97,31 +97,27 @@ k_tick=$(echo ${kernel_version[2]} | awk -F'-' '{print $2}')
# do not skip md patch - new d421.
#[ $k_maj_min -ge 605 ] && skip_md_patch=1

# Construct branch name from distribution codename {xenial,bionic,..} and kernel version
# Construct branch name from distribution codename {bionic,focal...} and kernel version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bionic can also be removed.
We support min focal.
Same for all places

@@ -43,14 +43,6 @@ PLATFORM=$(uname -n)
#fi
kernel_branch="master"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file at all

@@ -39,12 +39,12 @@ else
kernel_branch=$(choose_kernel_branch $LINUX_BRANCH)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this file

Copy link
Contributor Author

@AviaAv AviaAv Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We refer to it in our doc, installation_odroid.md, remove that file too?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@@ -36,12 +36,12 @@ retpoline_retrofit=0

LINUX_BRANCH=$(uname -r)

# Construct branch name from distribution codename {xenial,bionic,..} and kernel version
# Construct branch name from distribution codename {bionic, focal...} and kernel version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure bionic has kernel 4.16.
I think we can drop this file.
Just make sure that on the installation doc no more references to files we delete

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't mention this file in our doc, the only references we have to files we remove are in installation_odroid.md and DSO-1369.md, both seem fairly old

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also delete both

@@ -97,15 +96,9 @@ k_tick=$(echo ${kernel_version[2]} | awk -F'-' '{print $2}')
# do not skip md patch - new d421.
#[ $k_maj_min -ge 605 ] && skip_md_patch=1

# Construct branch name from distribution codename {bionic,focal...} and kernel version
# Construct branch name from distribution codename {focal, jammy...} and kernel version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try running this script so we can make sure it works before we merge.
This is our main patches script

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed the documentation with the modified script on a VM, the camera was detected fine

@Nir-Az Nir-Az merged commit 1affcb8 into IntelRealSense:development Apr 2, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants