Issue test error message only on last retry #13817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Mar 6, 2025
unit-tests/run-unit-tests.py
Outdated
| @@ -421,11 +421,11 @@ def devices_by_test_config( test, exceptions ): | |||
| continue | |||
|
|
|||
|
|
|||
| def test_wrapper_( test, configuration=None, repetition=1, retry=0, sns=None ): | |||
| def test_wrapper_( test, configuration=None, repetition=1, curr_retry=0, last_retry = 0, sns=None ): | |||
There was a problem hiding this comment.
Maybe for being clearer we can change last_retry to max_retries ? or retries_count?
Nir-Az
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_wrapper_function is called for each trial of the test. We want to issue error log only if this is the last retry.Note - A failed retry message is issued as debug level, we want error message only if all retries failed.