add limitation on number of captures in DQT #13735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Feb 3, 2025
Nir-Az
reviewed
Feb 3, 2025
Nir-Az
reviewed
Feb 3, 2025
Nir-Az
reviewed
Feb 3, 2025
Nir-Az
reviewed
Feb 11, 2025
| return pushed_style_var; | ||
| } | ||
|
|
||
| bool RsImGui::InputIntCentered(const char* label, int* v, int step, int step_fast, ImGuiInputTextFlags flags) |
There was a problem hiding this comment.
DO we really need a 100 code lines to center the text box?
I also see you used API we never used before like
IMGUI_TEST_ENGINE_ITEM_INFO
I believe this code is much more complex then it should be.
Please double check.
You can take as reference how Noy did the custom combo box text alignment
There was a problem hiding this comment.
this code was ported from ImGui with full support for the flags + modification to support text centering. i can remove this functionality.
Nir-Az
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracked by RSDSO-20044