Skip to content

Replace setup.py with pyproject.toml #13722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 6, 2025
Merged

Replace setup.py with pyproject.toml #13722

merged 7 commits into from
Mar 6, 2025

Conversation

Noy-Zini
Copy link
Contributor

Tracked on : [LRS-1214]

@Noy-Zini Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch 4 times, most recently from 320e414 to 7d51c23 Compare January 29, 2025 18:24
@Noy-Zini Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch 8 times, most recently from 227aa07 to fc04848 Compare February 25, 2025 15:09
@Noy-Zini Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch from fc04848 to 239769d Compare March 2, 2025 10:05
@Noy-Zini Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch 6 times, most recently from 1446fe4 to 421c763 Compare March 3, 2025 09:43
@Noy-Zini Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch from 421c763 to 61e1c6e Compare March 4, 2025 09:57
@Noy-Zini Noy-Zini force-pushed the replace-setup.py-with-pyproject.toml branch from d98cd48 to 9e52363 Compare March 6, 2025 09:15
@Noy-Zini Noy-Zini requested a review from Nir-Az March 6, 2025 09:42
Nir-Az
Nir-Az reviewed Mar 6, 2025
View reviewed changes
wrappers/python/pyproject.toml Outdated
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab --> spaces

@Nir-Az
Copy link
Collaborator

Nir-Az commented Mar 6, 2025

This should come with a CI PR too right?
Please elaborate on how it was tested

Nir-Az
Nir-Az approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit 1c9d0c0 into IntelRealSense:development Mar 6, 2025
24 of 25 checks passed
@Noy-Zini
Copy link
Contributor Author

Noy-Zini commented Mar 6, 2025

I tested each Python wheel generated by the build for the corresponding Python version and platform.
For each test, I installed the wheel using pip install, then verified it by importing pyrealsense2 and using it to open a context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noy-Zini @Nir-Az