Add Y16 support to D555 #13700
Merged
Add Y16 support to D555 #13700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remibettan
reviewed
Jan 23, 2025
src/proc/y16_10msb-to-y16.cpp
Outdated
| // License: Apache 2.0. See LICENSE file in root directory. | ||
| // Copyright(c) 2022 Intel Corporation. All Rights Reserved. | ||
|
|
||
| #include "y16_10msb-to-y16.h" |
There was a problem hiding this comment.
the file's name is weird: you have half "_" and half "-".
Besides that, you chose to rename to y16i_10msb_to_y16y16 - so one "y16 is missing in the file's name.
There was a problem hiding this comment.
Fixed the _ in the file name.
There are two files, existing that converts interleaved y16i to two y16 streams and was renamed. Plus a new file that handles one y16 stream with 10 bit data and scales it to 16 bit data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDEV-2612]
Format is "mono16" to be ROS compatible. Added processing block to handle 10bit data scale to 16bit.
Renamed
y16i-to-y10msby10msbtoy16i-10msb-to-y16y16.