Skip to content

dds-config improvements with multiple devices #13649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2025
Merged

dds-config improvements with multiple devices #13649

merged 1 commit into from
Jan 2, 2025

Conversation

maloel
Copy link
Contributor

@maloel maloel commented Jan 2, 2025

When multiple devices are available, the messaging and information were not helpful.
It now shows:

> rs-dds-config
-I- [DDS] Intel RealSense D555 s/n 336522303979, FW version 7.56.19865.539
-I- [DDS] Intel RealSense D555 s/n 341522301821, FW version 7.56.19826.493
-F- More than one device is available; please use --serial-number

@maloel maloel requested a review from remibettan January 2, 2025 13:04
remibettan
remibettan approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - please check LibCI failures

@maloel
Copy link
Contributor Author

maloel commented Jan 2, 2025

LGTM - please check LibCI failures

Reran and same tests passed; doesn't seem related.

@maloel maloel merged commit 2f2c885 into IntelRealSense:development Jan 2, 2025
22 of 23 checks passed
@maloel maloel deleted the dds-config branch January 2, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remibettan remibettan remibettan approved these changes

Assignees
No one assigned
Labels
dds enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maloel @remibettan