test-live-frames-fps time to measure based on fps #12544
Conversation
unit-tests/live/frames/test-fps.py
Outdated
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| # test:device each(D400*) | |||
| # test:donotrun:!nightly | |||
| # test:timeout 250 | |||
| # test:timeout 154 | |||
There was a problem hiding this comment.
test took 140.40848207473755 seconds
Do you think 154 is enough?
Since LibCI default timeout is 250 (IIRC) we can drop this line at all, we only need it when we want to increase , right?
There was a problem hiding this comment.
On win it took more
test took 151.15837216377258 seconds
There was a problem hiding this comment.
This is from my run with nightly context, the PR run skip this test :)
There was a problem hiding this comment.
Removed the line. Looks OK in CI
| @@ -66,14 +63,17 @@ def frame_cb(frame): | |||
|
|
|||
| delta_Hz = 1 | |||
| tested_fps = [6, 15, 30, 60, 90] | |||
| time_to_test_fps = [20, 13, 10, 5, 4] | |||
There was a problem hiding this comment.
I wonder how you chose those numbers :)
Maybe you can add a comment.
I tried following some logic that you ask for 300 frames but it's not persistent.
There was a problem hiding this comment.
No explicit rule. On one hand I wanted enough frames, around 300 looked like a good number. On the other hand I wanted to reduce the test time so on low FPS I settled for less frames.
Reducing the test time