Skip to content

small refactor for synthetic source #12482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Conversation

maloel
Copy link
Contributor

@maloel maloel commented Dec 5, 2023

Small refactor, hope you don't mind...

  • internal_frame_processor_callback<> -> frame_processor_callback (no longer template; proper release() call
  • rename processing.h -> synthetic-source-interface.h
  • remove synthetic_source_interface::get_c_wrapper() - wasn't used polymorphically

Tracked on [LRS-977]

@maloel maloel requested a review from Nir-Az December 5, 2023 10:57
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly don't understand much of the changes in this PR, but if it helps promote D555e and the CI pass I am OK with it :)

@maloel maloel merged commit ab8cd07 into IntelRealSense:development Dec 11, 2023
@maloel maloel deleted the synthetic branch December 11, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants