-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Acroname reset on libCI start #12426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we need to add this step to the jenkins script and not do it by default in libCI. |
Should enforce Acroname and reset it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good, you have another PR for deploy?
Yes, marked you as reviewer, I will also attach a CI run with it. |
@maloel , approved? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It took 19 seconds to reset, enumerate, etc.... that's pretty long.
My only reservation is about the case of the text, maybe I'd shorten it, too :)
08:57:11 -D- discovering Acroname modules ...
08:57:11 -D- ... Model: 19 LinkType: USB(serial: BD5D2C32)
08:57:11 -D- resetting Acroname...
08:57:13 -D- Reconnecting to Acroname
08:57:15 -D- Reconnected to Model: 19 LinkType: USB(serial: BD5D2C32)
08:57:29 -D- ... port 1: 104623061293 <pyrealsense2.device: D455 (S/N: 114222251278 FW: 5.15.1 UNLOCKED on USB3.2)>
08:57:30 -D- ... port 6: 012345678901 <pyrealsense2.device: D435 (S/N: 722312070458 FW: 5.15.1 UNLOCKED on USB3.2)>
I will fix the case issue. The 15 seconds are not from the reset.
First one add 5 sec sleep after turning off all ports Since it's the discovery phase we want to do it properly because if the camera is not identified here, all device related UT will fail. |
New log from build #6854:
|
This takes ~4 seconds on Linux / Windows according to the logs
Tracked on [LRS-933]