Skip to content

Acroname reset on libCI start #12426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 28, 2023
Merged

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Nov 19, 2023

  • Reset Acroname HUB at LibCI start to avoid regressions from previous builds
  • Currently we don't see many of those cases but this could be a good enhancement to keep libCI stable

This takes ~4 seconds on Linux / Windows according to the logs

Tracked on [LRS-933]

@Nir-Az Nir-Az requested a review from maloel November 19, 2023 14:46
@maloel
Copy link
Contributor

maloel commented Nov 20, 2023

This takes ~4 seconds on Linux / Windows according to the logs

I think we need to add this step to the jenkins script and not do it by default in libCI.
I.e., make this a command-line switch that's OFF by default, and the jenkins script will use it.

@maloel
Copy link
Contributor

maloel commented Nov 20, 2023

make this a command-line switch

python run-unit-tests.py ... --acroname-reset

Should enforce Acroname and reset it.

Copy link
Contributor

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good, you have another PR for deploy?

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Nov 27, 2023

Look good, you have another PR for deploy?

Yes, marked you as reviewer, I will also attach a CI run with it.

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Nov 27, 2023

@maloel , approved?

Copy link
Contributor

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took 19 seconds to reset, enumerate, etc.... that's pretty long.
My only reservation is about the case of the text, maybe I'd shorten it, too :)

08:57:11  -D- discovering Acroname modules ...
08:57:11  -D-     ... Model: 19 LinkType: USB(serial: BD5D2C32)
08:57:11  -D- resetting Acroname...
08:57:13  -D- Reconnecting to Acroname
08:57:15  -D- Reconnected to Model: 19 LinkType: USB(serial: BD5D2C32)
08:57:29  -D-     ... port 1: 104623061293 <pyrealsense2.device: D455 (S/N: 114222251278  FW: 5.15.1  UNLOCKED  on USB3.2)>
08:57:30  -D-     ... port 6: 012345678901 <pyrealsense2.device: D435 (S/N: 722312070458  FW: 5.15.1  UNLOCKED  on USB3.2)>

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Nov 27, 2023

It took 19 seconds to reset, enumerate, etc.... that's pretty long. My only reservation is about the case of the text, maybe I'd shorten it, too :)

08:57:11  -D- discovering Acroname modules ...
08:57:11  -D-     ... Model: 19 LinkType: USB(serial: BD5D2C32)
08:57:11  -D- resetting Acroname...
08:57:13  -D- Reconnecting to Acroname
08:57:15  -D- Reconnected to Model: 19 LinkType: USB(serial: BD5D2C32)
08:57:29  -D-     ... port 1: 104623061293 <pyrealsense2.device: D455 (S/N: 114222251278  FW: 5.15.1  UNLOCKED  on USB3.2)>
08:57:30  -D-     ... port 6: 012345678901 <pyrealsense2.device: D435 (S/N: 722312070458  FW: 5.15.1  UNLOCKED  on USB3.2)>

I will fix the case issue.
Not sure how to shorten it, I will try :)

The 15 seconds are not from the reset.
Its from this 2 lines

            acroname.disable_ports( sleep_on_change = 5 )
            acroname.enable_ports( sleep_on_change = MAX_ENUMERATION_TIME )

First one add 5 sec sleep after turning off all ports
Second line sleeps 10 seconds after enabling all ports.

Since it's the discovery phase we want to do it properly because if the camera is not identified here, all device related UT will fail.

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Nov 27, 2023

New log from build #6854:

14:13:14  -D- discovering Acroname modules ...
14:13:14  -D-     ... Model: 19 LinkType: USB(serial: E531405E)
14:13:14  -D- resetting Acroname...
14:13:16  error release -4
14:13:18  -D- reconnected
14:13:33  -D-     ... port 5: 015223050005 <pyrealsense2.device: D455 (S/N: 013322250065  FW: 5.15.1  UNLOCKED  on USB3.2)>
14:13:33  -D-     ... port 2: 012345678901 <pyrealsense2.device: D435 (S/N: 728612070268  FW: 5.15.1  UNLOCKED  on USB3.2)>
14:13:33  -I- Running under context: ['nightly', 'linux']

@Nir-Az Nir-Az merged commit 0f0313b into IntelRealSense:development Nov 28, 2023
@Nir-Az Nir-Az deleted the acroname-reset branch January 9, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants