add tclap interface library #12350
Merged
add tclap interface library #12350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Nov 5, 2023
third-party/tclap/CMakeLists.txt
Outdated
| @@ -0,0 +1,8 @@ | |||
| # License: Apache 2.0. See LICENSE file in root directory. | |||
| # Copyright(c) 2023 Intel Corporation. All Rights Reserved. | |||
| cmake_minimum_required( VERSION 3.10 ) | |||
There was a problem hiding this comment.
Why do we limit the minimum version?
There was a problem hiding this comment.
CMake makes you put a minimum-required in the beginning. Maybe not for everything, but I recall it complaining.
Anyway, U18 is our minimum, so 3.10.
What's most interesting to me is that the static_analysis hasn't complained...!
And when I check it, it says:
The test PASSED, current CMake version is VERSION 3.10.0 and it is not higher than VERSION 3.8.0
LOL?
There was a problem hiding this comment.
I removed it, let's see what happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tclap is our command-line processing library.
We have to manually add its include directory in all projects.
Instead, it is now an interface library so you can just say you depend on it in
target_link_libraries.Tracked on [LRS-943]