Image quality test #12281
Merged
Image quality test #12281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Oct 11, 2023
Nir-Az
reviewed
Oct 11, 2023
Nir-Az
reviewed
Oct 11, 2023
Nir-Az
reviewed
Oct 11, 2023
Nir-Az
reviewed
Oct 11, 2023
| sensor.set_option(rs.option.emitter_enabled, 0) | ||
|
|
||
| frames = pipeline.wait_for_frames() | ||
| for i in range(30): |
There was a problem hiding this comment.
Please add a comment about this loop
OhadMeir
reviewed
Oct 11, 2023
OhadMeir
reviewed
Oct 11, 2023
OhadMeir
reviewed
Oct 11, 2023
OhadMeir
reviewed
Oct 11, 2023
OhadMeir
reviewed
Oct 12, 2023
OhadMeir
reviewed
Oct 12, 2023
OhadMeir
reviewed
Oct 12, 2023
OhadMeir
reviewed
Oct 12, 2023
OhadMeir
reviewed
Oct 12, 2023
OhadMeir
reviewed
Oct 12, 2023
OhadMeir
reviewed
Oct 12, 2023
OhadMeir
reviewed
Oct 12, 2023
OhadMeir
reviewed
Oct 15, 2023
|
|
||
| if save: | ||
| file_name = "output_stream.png" | ||
| print("Saved image in", os.getcwd() + "\\" + file_name) |
There was a problem hiding this comment.
Don't print use the log mechanism you have imported.
- There isn't always a screen, log messages are kept in a file if needed.
- You can set the verbosity level f/e/i/d (fatal don't continue / error but try to continue / info message / debug message only)
|
Overall looks good. Since we had problems with some runs that may be affected from the camera positioning and lighting condition, and currently we all work from home, try changing the resolution to 1cm. Check both day and night (lights out in the lab) if we get a meaningful depth, it might help. |
Nir-Az
reviewed
Oct 16, 2023
Nir-Az
reviewed
Oct 16, 2023
Nir-Az
reviewed
Oct 16, 2023
Nir-Az
reviewed
Oct 16, 2023
Nir-Az
reviewed
Oct 16, 2023
Nir-Az
reviewed
Oct 16, 2023
|
|
||
| meaningful_depth = True | ||
| for key in dists: | ||
| if dists[key] > total*0.9: |
There was a problem hiding this comment.
Please add a comment explaining this
Nir-Az
reviewed
Oct 16, 2023
Nir-Az
reviewed
Oct 16, 2023
Nir-Az
reviewed
Oct 16, 2023
Nir-Az
reviewed
Oct 23, 2023
| log.f("Error getting depth frame") | ||
| return False | ||
| if DEBUG_MODE and not color: | ||
| log.d("Error getting color frame") |
|
Please check he CI failure, always. You need to make sure your test run on all required platforms, and passed |
|
Great first PR!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-902]