Skip to content

add rs2_device_is_connected, rs2::device::is_connected #12240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 1, 2023

Conversation

maloel
Copy link
Contributor

@maloel maloel commented Sep 30, 2023

The device_interface::is_valid() function is only exposed today through device_hub::is_connected(), which calls it directly without any more logic.

This exposes the same functionality via direct access in rs2::device and rs2_device_is_connected.

Tracked on [LRS-895]

@maloel maloel requested a review from ev-mp September 30, 2023 10:06
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment inside

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel maloel merged commit a3d2f8f into IntelRealSense:development Oct 1, 2023
@maloel maloel deleted the is-connected branch October 1, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants