D457 Segfault when calling get_motion_intrinsics #12042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b8bcbb to
bc9fef8
Compare
|
Nice catch!, as discussed, please add a unit test for each(D400) and later on PR with each(D500) on the relevant branch |
bc9fef8 to
e9775c8
Compare
Nir-Az
reviewed
Aug 7, 2023
|
Please remove this file you added |
Nir-Az
reviewed
Aug 7, 2023
Nir-Az
reviewed
Aug 7, 2023
| @@ -0,0 +1,33 @@ | |||
| # License: Apache 2.0. See LICENSE file in root directory. | |||
There was a problem hiding this comment.
Please rename the file to test-motion.py
Currently when it runs it looks like this
intrinsics-motion-intrinsics
There was a problem hiding this comment.
The test was renamed.
Nir-Az
reviewed
Aug 7, 2023
Nir-Az
reviewed
Aug 7, 2023
Nir-Az
reviewed
Aug 8, 2023
Nir-Az
approved these changes
Aug 8, 2023
This was referenced Aug 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [DSO-19103]
Tracked on [LRS-845]