Skip to content

fix dds query_devices: discard non-running devices #11650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 3, 2023

Conversation

maloel
Copy link
Contributor

@maloel maloel commented Apr 3, 2023

Recent GHA runs of the DDS tests are failing. This is an attempt to stabilize.

In general, GHA tasks run on only two cores and some of our tests use multiple processes and multiple threads and are therefore sensitive.

At least one problem seen is:

  • The broadcaster broadcasts a device
  • The client sees it in thread 1
  • The client is waiting for devices in thread 2 (python)
    • Thread 2 is, every second, performing a query_devices() until it sees the device
    • Query devices sees the device (it's part of the devices that can be iterated on the device-watcher)
    • Thread 2 wakes up and tries to act on the device

But Thread 1 is not yet done initializing the device!

Changes:

  • fix rspy.test.context initialization to []
  • add "gha" to rspy.test.context using GITHUB_ACTIONS env var
    • i.e., you can now limit libci tests to be GHA-specific
  • allow 3x timeout waiting for dds devices under GHA
  • give dds test-librs-device-properties context a name
  • fix dds query_devices: discard non-running devices; now product-line sensitive

@maloel maloel requested a review from OhadMeir April 3, 2023 07:11
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need the timeout * 3, but we can check the logs and see if indeed needed.
The important fix is not adding the device to the list until it is_running()

@maloel maloel merged commit 5bd6870 into IntelRealSense:dds Apr 3, 2023
@maloel maloel deleted the gha branch April 3, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants