Skip to content

Merge MIPI branch into development #11169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 354 commits into from
Dec 6, 2022
Merged

Conversation

maloel
Copy link
Contributor

@maloel maloel commented Dec 5, 2022

No description provided.

ev-mp and others added 30 commits May 29, 2022 11:15
Fix hyperlink for user notification not opened due to overlapping textbox

(cherry picked from commit a587bcd)
Change-Id: Ia0946bf37741ddb8882ff9b0e99c66de8c9aace8
hdr test excluded from tests
on-chip-calib.cpp: calibrate now uses calib_dev.add_calibration_frame for tare_calibration.
fix depth_auto_calibration_example.py to use either host_assistance tare calibration or firware-only calibration.

add_calibration_frame works with OCC.

Fix realsense-viewer and depth_auto_calibration_example.py to demonstrate usage.

update progress.

fix health.

fixed "float* health" to "float* const health" (const pointer to float)

fix return health value to python
modified the callback in depth_auto_calibration_example.py to a more graphical one.

clean

use existing function to compare FW version with a given minimal one.

Add timeout of 30 seconds to host assistant calibration process.

convert speed to enum

convert host_assistance to enum

validate speed value

replace try-catch sections with if-else sections as flow control handlers.
…gress.

ask firmware for valid depth values.

Throw if firmware values are not yet set.
DEBUG: Save raw images
…is image_size / resize_factor. i.e. 5 - means work on central width/5, height/5 image of the image.

fix bug in ROI calculation in host assistance tare calibration in collect_depth_frame_sum

Save images for host assistance tare calibration
Save all images with indexes

fix condition of pixel validity to include threshold values.

Save fill_factor_final.txt

Fix passing exception messages to python wrapper.

Fix depth_auto_calibration_example.py import for linux.

remove redundant parameters in depth_auto_calibration_example.py

remove log messages.
…nter=1 we get the image of frame_counter 0 etc. This fix is meant to compensate for that.

skip first frame in tare calculations.

remove debug temporary files.

fix progress function usage

Fix rebase inconsistencies
…can" to 1 to enable.

Add debug file to working directory: all_frame_numbers.txt with the following format: frame_number, prev_frame_number, total_frame, frame_time, computer_time
Add timestamps to saved debug images filenames - to avoid overriding.

For OCC: Add offset of +1 when using host with iterative mode and +2 with host without iterative mode. (fill_rate[idx+offset] = calc_fill_rate(idx) )

Reduce Offset to 0 in interactive mode and 1 in regular mode.

Remove saving debug images and files

realsense-viewer default mode for host-assisted OCC changed to interactive.
rename rs2_add_calibration_frame to rs2_process_calibration_frame
…h_remi

# Conflicts:
#	common/notifications.cpp
#	common/on-chip-calib.cpp
#	include/librealsense2/utilities/time/waiting-on.h
#	src/auto-calibrated-device.h
#	src/ds5/ds5-auto-calibration.h
#	src/ds5/ds5-device.cpp
#	src/rs.cpp
#	unit-tests/utilities/time/test-waiting-on.cpp
#	wrappers/python/examples/depth_auto_calibration_example.py
…with host without iterative mode. (fill_rate[idx+offset] = calc_fill_rate(idx) )

(cherry picked from commit 4ea51b4)

# Conflicts:
#	src/ds5/ds5-auto-calibration.cpp
ev-mp and others added 26 commits November 7, 2022 07:24
(cherry picked from commit b2b64fb)
Verify thermal Loop is disabled before OCC/Tare.
Verify Laser is on for OCC/Tare
Adjust timeouts
Hot fix for OCC HA type to use legacy UCAL demo scripts.
Update the OCC/Tare Demo code with recommended configuration
Verify thermal Loop is disabled before OCC/Tare.
Verify Laser is on for OCC/Tare
Adjust timeouts

(cherry picked from commit fa6eedc)
@maloel maloel requested a review from Nir-Az December 5, 2022 11:31
@maloel maloel merged commit 46440f4 into IntelRealSense:development Dec 6, 2022
@maloel maloel deleted the mipi2dev branch December 6, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants