-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Merge MIPI branch into development #11169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hyperlink for user notification not opened due to overlapping textbox (cherry picked from commit a587bcd)
Change-Id: Ia0946bf37741ddb8882ff9b0e99c66de8c9aace8
CR fixes
… the existing warning cosmetics CR updates
hdr test excluded from tests
on-chip-calib.cpp: calibrate now uses calib_dev.add_calibration_frame for tare_calibration. fix depth_auto_calibration_example.py to use either host_assistance tare calibration or firware-only calibration. add_calibration_frame works with OCC. Fix realsense-viewer and depth_auto_calibration_example.py to demonstrate usage. update progress. fix health. fixed "float* health" to "float* const health" (const pointer to float) fix return health value to python modified the callback in depth_auto_calibration_example.py to a more graphical one. clean use existing function to compare FW version with a given minimal one. Add timeout of 30 seconds to host assistant calibration process. convert speed to enum convert host_assistance to enum validate speed value replace try-catch sections with if-else sections as flow control handlers.
…gress. ask firmware for valid depth values. Throw if firmware values are not yet set.
DEBUG: Save raw images
…is image_size / resize_factor. i.e. 5 - means work on central width/5, height/5 image of the image. fix bug in ROI calculation in host assistance tare calibration in collect_depth_frame_sum Save images for host assistance tare calibration Save all images with indexes fix condition of pixel validity to include threshold values. Save fill_factor_final.txt Fix passing exception messages to python wrapper. Fix depth_auto_calibration_example.py import for linux. remove redundant parameters in depth_auto_calibration_example.py remove log messages.
…nter=1 we get the image of frame_counter 0 etc. This fix is meant to compensate for that. skip first frame in tare calculations. remove debug temporary files. fix progress function usage Fix rebase inconsistencies
…can" to 1 to enable. Add debug file to working directory: all_frame_numbers.txt with the following format: frame_number, prev_frame_number, total_frame, frame_time, computer_time Add timestamps to saved debug images filenames - to avoid overriding. For OCC: Add offset of +1 when using host with iterative mode and +2 with host without iterative mode. (fill_rate[idx+offset] = calc_fill_rate(idx) ) Reduce Offset to 0 in interactive mode and 1 in regular mode. Remove saving debug images and files realsense-viewer default mode for host-assisted OCC changed to interactive. rename rs2_add_calibration_frame to rs2_process_calibration_frame
…h_remi # Conflicts: # common/notifications.cpp # common/on-chip-calib.cpp # include/librealsense2/utilities/time/waiting-on.h # src/auto-calibrated-device.h # src/ds5/ds5-auto-calibration.h # src/ds5/ds5-device.cpp # src/rs.cpp # unit-tests/utilities/time/test-waiting-on.cpp # wrappers/python/examples/depth_auto_calibration_example.py
…with host without iterative mode. (fill_rate[idx+offset] = calc_fill_rate(idx) ) (cherry picked from commit 4ea51b4) # Conflicts: # src/ds5/ds5-auto-calibration.cpp
(cherry picked from commit 0f8dae0)
OCC/Tare integration with MIPI SKU
(cherry picked from commit b2b64fb)
Verify thermal Loop is disabled before OCC/Tare. Verify Laser is on for OCC/Tare Adjust timeouts
Hot fix for OCC HA type to use legacy UCAL demo scripts. Update the OCC/Tare Demo code with recommended configuration
…h HA support (cherry picked from commit 9eb4ea5)
Verify thermal Loop is disabled before OCC/Tare. Verify Laser is on for OCC/Tare Adjust timeouts (cherry picked from commit fa6eedc)
Nir-Az
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.