wa added in frame size assertion, and processing block for mipi added #10794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
reviewed
Aug 18, 2022
src/sensor.cpp
Outdated
Comment on lines
479
to
486
| if (req_profile_base->get_format() == RS2_FORMAT_Y12I) | ||
| { | ||
| assert(expected_size == sizeof(byte) * f.frame_size || | ||
| expected_size * 3 / 4 == sizeof(byte) * f.frame_size); | ||
| if (expected_size == sizeof(byte) * f.frame_size) | ||
| memcpy((void*)fh->get_frame_data(), f.pixels, expected_size); | ||
| if (expected_size * 3 / 4 == sizeof(byte) * f.frame_size) | ||
| memcpy((void*)fh->get_frame_data(), f.pixels, expected_size * 3 / 4); |
There was a problem hiding this comment.
Maybe we can use a short-handed style:
expected_size *= (expected_size * 3 / 4 == sizeof(byte) * f.frame_size)) ? 3/4 : 1;
and then you can leave the original assert and memcpy in place
There was a problem hiding this comment.
great idea - thanks
21230f0 to
f94c2c9
Compare
f94c2c9 to
8366f5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: DSO-18458