Fixed bug - Setting Depth Units in realsense_viewer fails #1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracked on: DSO-9736
ev-mp
reviewed
Jun 27, 2018
common/model-views.cpp
Outdated
| if (ImGui::SliderFloat(id.c_str(), &value, | ||
| range.min, range.max, "%.4f")) | ||
| { | ||
| auto loffset = fmod(value, range.step); |
There was a problem hiding this comment.
Looks good, please verify that this hold for negative values as well
dorodnic
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method for calculating the float value that is passed from the realsense_viewer controls slider has been changed. We calculate the left and right offset between the received slider input and the next step and set the value that is closer.
For example: for slider input: 0.4 and step: 0.25 the nearest value will be 0.5.
Tracked on: DSO-9736