Skip to content

Documentation improvements #2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Aug 18, 2024
Merged

Documentation improvements #2091

merged 30 commits into from
Aug 18, 2024

Conversation

88572
Copy link
Contributor

@88572 88572 commented Jul 7, 2024 •
edited
Loading

TODO:

  • Apps
  • Watchfaces

@88572 88572 marked this pull request as ready for review July 7, 2024 19:12
tituscmd
tituscmd suggested changes Jul 7, 2024
View reviewed changes
Copy link
Contributor

@tituscmd tituscmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not perfectly sure if 2048 and Pong actually need to be called 2 and Paddle out of copyright reasons, so someone else might need to confirm that.

88572 and others added 9 commits July 8, 2024 08:33
@88572 @tituscmd
Update doc/gettingStarted/Applications.md
05c1245 
Co-authored-by: tituscmd <154823939+tituscmd@users.noreply.github.com>
@88572 @tituscmd
Update README.md
fbebbfa 
Co-authored-by: tituscmd <154823939+tituscmd@users.noreply.github.com>
@88572 @tituscmd
Update README.md
51b67d4 
Co-authored-by: tituscmd <154823939+tituscmd@users.noreply.github.com>
@88572 @tituscmd
Update doc/gettingStarted/Applications.md
9668c26 
Co-authored-by: tituscmd <154823939+tituscmd@users.noreply.github.com>
@88572 @tituscmd
Update doc/gettingStarted/Applications.md
ec980bf 
Co-authored-by: tituscmd <154823939+tituscmd@users.noreply.github.com>
@88572 @tituscmd
Apply suggestions from code review
20be2a3 
Co-authored-by: tituscmd <154823939+tituscmd@users.noreply.github.com>
@88572 @tituscmd
Apply suggestions from code review
7c2686c 
Co-authored-by: tituscmd <154823939+tituscmd@users.noreply.github.com>
@88572
2048->2 in heading, hopefully merged for 1.15
445a1b6
@88572
Update Applications.md
e289dc3
JF002
JF002 requested changes Aug 18, 2024
View reviewed changes
Copy link
Collaborator

@JF002 JF002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the documentation and adding the list of apps and watch faces!
Please review the following comments and then we'll merge it ;-)

@JF002 JF002 added the documentation Improvements or additions to documentation label Aug 18, 2024
@JF002 JF002 added this to the 1.15.0 milestone Aug 18, 2024
@88572
Copy link
Contributor Author

88572 commented Aug 18, 2024

Thank you for updating the documentation and adding the list of apps and watch faces!
Please review the following comments and then we'll merge it ;-)

I've fixed those up!

@JF002
Copy link
Collaborator

JF002 commented Aug 18, 2024

That was fast, thanks!

@JF002 JF002 merged commit a3dbcd6 into InfiniTimeOrg:main Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JF002 JF002 JF002 approved these changes

+1 more reviewer

@tituscmd tituscmd tituscmd requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@88572 @JF002 @tituscmd