Rewrite APKPure Source to use the mobile API instead of web scraping #2305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apks install resulted in "incompatible" error with some apps on testing
|
Nice, this looks really good 🎉 |
|
should be ready for merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing #2290 and #2296 I discovered that the APKPure website can be pretty inconsistent when dealing with different variants, which can be both for different architectures or versions where the version number stays the same but the version code changes.
So I reverse-engineered the API used by the APKPure app, which provides a nice consistent versions endpoint, and re-implemented the APKPure Source based on that. I've tested it with all apps that were mentioned in the relevant issues and it just seems to work without any issues.
I added a new additional setting as well (
useFirstApkOfVersion). Since some apps have many compatible apks for the same version, this setting just selects the newest of the resulting apks, allowing the user to skip the apk selection and better enable automatic updates.I'm unsure how the localization system works, so providing the user facing string is still missing, any advice on how to do this would be appreciated.