Added continuous ligatures #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just fixed the ligatures being smaller bug, so now everything should work as intended |
|
Interesting, this is definitely something I've been meaning to look into. Thank you for working on this, will hopefully be able to review it properly in the next couple of days! |
|
Thanks for your patience with this review, life got in the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR for #115
These ligatures make various cli tools look so much nicer:
Cargo:
Pacman:
I was thinking of adding another type, 2 headed ligatures, so that things like <=> can be expanded, but i'm not sure if there's any point in that.
But there's also currently a bug where shorter ligatures are slightly smaller:
I think there might be something wrong with the generateImage function.