Try to Join Polygons #112
Merged
Try to Join Polygons #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdreesInc
reviewed
Feb 20, 2023
| break | ||
| else: | ||
| raise RuntimeError( | ||
| f'Should not happened {inner_poly} {outer_poly}') |
There was a problem hiding this comment.
This basically guarantees it will happen at least once
|
From what I can tell, the result looks good to me and fixes the issues I saw. Thank you once again for your continued work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to join inner and outer polygon by using common point between them. This does not work with polygons that does not have common points (deep holes), so it is left untouched. Should mostly fix #110.