review fix: ignore a test for memory issues on the CI #2366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One test has been added by @nharrand in #2112 to show the usage of the new dependency resolver. However this test consumes too much memory on our CI, on the job used to deploy maven artefacts: > [ERROR] Tests run: 7, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 68.03 s <<< FAILURE! - in spoon.MavenLauncherTest [ERROR] testTypeResolution(spoon.MavenLauncherTest) Time elapsed: 38.801 s <<< ERROR! java.lang.OutOfMemoryError: GC overhead limit exceeded at spoon.MavenLauncherTest.testTypeResolution(MavenLauncherTest.java:25) https://ci.inria.fr/sos/job/Spoon-Snapshot-Deployer/1689/console I propose to ignore the test for now.
|
Maybe we should check why the memory consumption is so high |
yes that's what I want to do, but right now the snapshots are not deployed anymore because of that test. So I propose to ignore it for fixing the deployment, and then to look what happens in the test concerning memory consumption. |
|
So ok to merge it @tdurieux ? |
|
@monperrus would you merge it? We don't have any snapshot since 10 days because of that issue... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test has been added by @nharrand in #2112 to show the usage of the new dependency resolver. However this test consumes too much memory on our CI, on the job used to deploy maven artefacts:
https://ci.inria.fr/sos/job/Spoon-Snapshot-Deployer/1689/console
I propose to ignore the test for now.