Skip to content

Simplify syncing #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

Simplify syncing #309

merged 1 commit into from
Jun 12, 2025

Conversation

MikeMcQuaid
Copy link
Member

  • Reduce the number of custom syncing exceptions.
  • Add more logic to actionlint.yml workflow to allow sharing.

Requires all of Homebrew/ruby-macho#871 Homebrew/rubydoc.brew.sh#775 Homebrew/brew#20077 Homebrew/homebrew-core#226572

p-linnane
p-linnane approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks!

woodruffw
woodruffw approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well 🙂

@Rylan12 Rylan12 mentioned this pull request Jun 12, 2025
Merged
@MikeMcQuaid MikeMcQuaid force-pushed the workflows_tweaks branch 3 times, most recently from ca5d042 to 398a6fd Compare June 12, 2025 15:55
@MikeMcQuaid
Simplify syncing
e6e84cc 
- Reduce the number of custom syncing exceptions.
- Add more logic to `actionlint.yml` workflow to allow sharing.
@MikeMcQuaid MikeMcQuaid merged commit 07018f0 into main Jun 12, 2025
29 checks passed
@MikeMcQuaid MikeMcQuaid deleted the workflows_tweaks branch June 12, 2025 17:04
Bo98
Bo98 reviewed Jun 13, 2025
View reviewed changes
.github/actions/sync/shared-config.rb
Comment on lines -100 to -102
custom_dependabot_repos = %w[
.github
].freeze
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want to remove this as it overwrites the base template: #313

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bo98 on it, thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#317

@carlocab carlocab mentioned this pull request Jul 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 left review comments

@woodruffw woodruffw woodruffw approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MikeMcQuaid @Bo98 @woodruffw @p-linnane