Skip to content

Conversation

apjanke
Copy link
Contributor

@apjanke apjanke commented Feb 12, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Addresses #19696.

QuestDB is not compatible with Java 9, per maintainer comments. This PR makes it run under Java 8 only.

@ilovezfs ilovezfs merged commit 60d82bd into Homebrew:master Feb 12, 2018
@ilovezfs
Copy link
Contributor

Thanks @apjanke! Why do I suspect we'll never be able to kill off Java 8?

@ilovezfs ilovezfs mentioned this pull request Feb 12, 2018
@apjanke
Copy link
Contributor Author

apjanke commented Feb 12, 2018

Your suspicions are well founded. In my work life, I'm still writing Java 7 right now. And in my 18 years of professional Java coding, Java 9 is the breakingest change I've ever seen. Good luck to us all getting over that hump.

@apjanke apjanke deleted the questdb-java-8 branch February 12, 2018 16:19
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants