javarepl: require Java 8 specifically #24032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilovezfs
reviewed
Feb 12, 2018
Formula/javarepl.rb
Outdated
| def install | ||
| libexec.install "javarepl-#{version}.jar" | ||
| bin.write_jar_script libexec/"javarepl-#{version}.jar", "javarepl" | ||
| bin.write_jar_script libexec/"javarepl-#{version}.jar", "javarepl", :"java_version" => "1.8" |
There was a problem hiding this comment.
Are the quotes around java_version needed?
ilovezfs
suggested changes
Feb 12, 2018
|
new tag? Not sure I follow. |
|
@apjanke you're using the new DSL so any regular users who are on brew's last stable tag not HEAD will get an install failure if I merge this. It would be best to ditch the new DSL for this PR so that it doesn't sit and rot. |
|
Ah, gotcha. Amended. How about this? |
|
seems fine |
ilovezfs
approved these changes
Feb 12, 2018
|
🚀 thank you :) |
Closed
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Updates
javareplto require exactly Java 1.8, fixing Java 9 breakage.Addresses #19696.