scala@2.10: require Java 8 specifically #24041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilovezfs
reviewed
Feb 12, 2018
Formula/scala@2.10.rb
Outdated
| @@ -37,7 +37,10 @@ def install | |||
| doc.install Dir["doc/*"] | |||
| share.install "man" | |||
| libexec.install "bin", "lib" | |||
| bin.install_symlink Dir["#{libexec}/bin/*"] | |||
| Dir["#{libexec}/bin/*"].each do |file| | |||
There was a problem hiding this comment.
why aren't we using env_script_all_files?
There was a problem hiding this comment.
The tests fail when I try to do it that way. I have no idea why.
There was a problem hiding this comment.
Okay, I think I've got it figured out. Amended.
There was a problem hiding this comment.
God help me, I've been writing code for near 20 years now, and the Homebrew codebase is one of the most difficult ones I've worked with.
|
Thank you! Yes please scala@2.11 |
Closed
4 tasks
|
Bam! #24045 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?Addresses #19696.
Makes Scala 2.10 use Java 8 specifically.
Looks like there's a lot of work to be done in Scala for Java 9 support:
scala/scala-dev#139
scala/docs.scala-lang#1000
So it doesn't seem likely that the 2.10 and 2.11 series will get Java 9 support soon. So it seems legit to pin them to Java 8.
(I also tested the new Scala 2.10.7 release, whose release notes say it has "(partial) support" for Java 9, but it still broke under a Homebrew install.)
If this PR is accepted, I'll do the same for
scala@2.11.