Skip to content

fdroidcl: fix fragile test #232861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2025
Merged

fdroidcl: fix fragile test #232861

merged 1 commit into from
Aug 8, 2025

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Aug 8, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Fragile test failing found in

  ==> /opt/homebrew/Cellar/fdroidcl/0.8.1/bin/fdroidcl list categories
  Error: fdroidcl: failed
  An exception occurred within a child process:
    Minitest::Assertion: --- expected
  +++ actual
  @@ -1,38 +1,57 @@
   "App Store & Updater
  +Bookmark
   Browser
  +Calculator
   Calendar & Agenda
   Cloud Storage & File Sync
   Connectivity
   DNS & Hosts
   Development
  +Draw
  +Ebook Reader
   Email
   File Encryption & Vault
   File Transfer
  +Finance Manager
  +Gallery
   Games
   Graphics
  +Icon Pack
   Internet
   Keyboard & IME
  +Launcher
   Local Media Player
   Messaging
   Money
   Multimedia
   Navigation
   News
  +Note
   Online Media Player
  +Pass Wallet
   Password & 2FA
   Phone & SMS
   Podcast
  +Public Transport Map & Timetable
   Reading
  +Recipe Manager
   Science & Education
   Security
  +Shopping List
   Social Network
   Sports & Health
   System
  +Task
  +Text Editor
   Theming
   Time
  +Translation & Dictionary
  +Unit Convertor
   VPN & Proxy
   Voice & Video Chat
   Wallet
  +Wallpaper
   Weather
  +Workout
   Writing
   "

This now test just a few prominent categories.

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Aug 8, 2025
@stefanb stefanb force-pushed the fdroidcl-fix-fragile-test branch 2 times, most recently from 1dd37b9 to 0931122 Compare August 8, 2025 18:31
@stefanb stefanb marked this pull request as ready for review August 8, 2025 18:40
@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Aug 8, 2025
carlocab
carlocab reviewed Aug 8, 2025
View reviewed changes
@stefanb stefanb mentioned this pull request Aug 8, 2025
Merged
62 tasks
@stefanb stefanb force-pushed the fdroidcl-fix-fragile-test branch 2 times, most recently from 8c73cd5 to 294b4ad Compare August 8, 2025 19:50
@stefanb stefanb force-pushed the fdroidcl-fix-fragile-test branch from 294b4ad to 3638d58 Compare August 8, 2025 20:00
@stefanb stefanb requested a review from carlocab August 8, 2025 20:08
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 8, 2025
Merged via the queue into main with commit c27f6d0 Aug 8, 2025
29 checks passed
@BrewTestBot BrewTestBot deleted the fdroidcl-fix-fragile-test branch August 8, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanb @carlocab @BrewTestBot