Skip to content

libdbusmenu 16.04.0 (new formula) #230809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

libdbusmenu 16.04.0 (new formula) #230809

merged 2 commits into from
Jul 22, 2025

Conversation

ReenigneArcher
Copy link
Contributor

@ReenigneArcher ReenigneArcher commented Jul 21, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This PR adds libdbusmenu, which is a dependency for a third-party tap I have (https://github.com/LizardByte/homebrew-homebrew/blob/master/Formula/s/sunshine.rb). There are actually a few dependencies I will be submitting, though this is the first one on the list.

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Jul 21, 2025
@ReenigneArcher ReenigneArcher force-pushed the add/libdbusmenu branch 6 times, most recently from ea052d4 to 89e44e4 Compare July 22, 2025 00:13
@github-actions github-actions bot added the perl Perl use is a significant feature of the PR or issue label Jul 22, 2025
@ReenigneArcher ReenigneArcher force-pushed the add/libdbusmenu branch 14 times, most recently from 29ab267 to dc51d37 Compare July 22, 2025 03:08
@ReenigneArcher
Copy link
Contributor Author

ReenigneArcher commented Jul 22, 2025 •
edited
Loading

Could there be an exception for this formula?

   libdbusmenu
    * Formulae should not require patches to build. Patches should be submitted and accepted upstream first.

Patching is required to get this building:

TBH, I have no idea how to contribute on launchpad, but it seems very inactive. I also understand that Homebrew only wants stuff actively maintained by upstream; however as this is a dependency of common Linux libraries I believe an exception should be made for this.

Additionally, can you disable fail fast for tests? This is brutal to test when everything fails. I'm not sure this package is even feasible on macOS yet, and the main goal of this is for Linux. I had to add a ton of packages to get this to work, which I didn't need in my own tap.

Edit: Marked ready in hopes a maintainer will see this and provide a response. Thanks!

@ReenigneArcher ReenigneArcher force-pushed the add/libdbusmenu branch 4 times, most recently from b12ebd6 to 9901908 Compare July 22, 2025 04:06
@ReenigneArcher ReenigneArcher changed the title libdbusmenu 16.04: new formula libdbusmenu 16.04 (new formula) Jul 22, 2025
@ReenigneArcher ReenigneArcher marked this pull request as ready for review July 22, 2025 12:21
@carlocab carlocab added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jul 22, 2025
@ReenigneArcher ReenigneArcher force-pushed the add/libdbusmenu branch 2 times, most recently from bbc1af5 to cf2b7ae Compare July 22, 2025 16:52
@ReenigneArcher ReenigneArcher marked this pull request as ready for review July 22, 2025 17:23
@ReenigneArcher
Copy link
Contributor Author

This is ready for review now and all tests have passed.

@carlocab carlocab removed the audit failure CI fails while auditing the software label Jul 22, 2025
carlocab
carlocab reviewed Jul 22, 2025
View reviewed changes
carlocab
carlocab previously approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ReenigneArcher
Copy link
Contributor Author

I don't think removing the livecheck would cause this failure. Could it be due to caching?

  make[3]: Entering directory '/var/tmp/libdbusmenu-20250722-13406-1mahij/libdbusmenu-16.04.0/libdbusmenu-gtk'
   /usr/bin/mkdir -p '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/include/libdbusmenu-gtk3-0.4/libdbusmenu-gtk/'
   /usr/bin/mkdir -p '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/include/libdbusmenu-gtk3-0.4/libdbusmenu-gtk/'
   /usr/bin/mkdir -p '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/lib/pkgconfig'
   /usr/bin/mkdir -p '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/lib'
   /bin/bash ../libtool   --mode=install /usr/bin/install -c   libdbusmenu-gtk3.la '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/lib'
   /usr/bin/install -c -m 644 dbusmenu-gtk.h client.h menu.h menuitem.h parser.h '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/include/libdbusmenu-gtk3-0.4/libdbusmenu-gtk/'
   /usr/bin/install -c -m 644 dbusmenu-gtk.h client.h menu.h menuitem.h parser.h '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/include/libdbusmenu-gtk3-0.4/libdbusmenu-gtk/'
   /usr/bin/install -c -m 644 dbusmenu-gtk3-0.4.pc '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/lib/pkgconfig'
  /usr/bin/install: cannot create regular file '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/include/libdbusmenu-gtk3-0.4/libdbusmenu-gtk/dbusmenu-gtk.h': File exists
  /usr/bin/install: cannot create regular file '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/include/libdbusmenu-gtk3-0.4/libdbusmenu-gtk/client.h': File exists
  /usr/bin/install: cannot create regular file '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/include/libdbusmenu-gtk3-0.4/libdbusmenu-gtk/menu.h': File exists
  /usr/bin/install: cannot create regular file '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/include/libdbusmenu-gtk3-0.4/libdbusmenu-gtk/menuitem.h': File exists
  /usr/bin/install: cannot create regular file '/home/linuxbrew/.linuxbrew/Cellar/libdbusmenu/16.04.0/include/libdbusmenu-gtk3-0.4/libdbusmenu-gtk/parser.h': File exists
  make[3]: *** [Makefile:875: install-libdbusmenu_gtk3includeHEADERS] Error 1
  make[3]: *** Waiting for unfinished jobs....
  make[3]: *** [Makefile:896: install-libdbusmenu_gtkincludeHEADERS] Error 1

@github-actions GitHub Actions
Copy link
Contributor

⛔ It looks like @BrewTestBot cannot push to your PR branch. For future pull requests, please allow maintainers to edit your PR to simplify the merge process.

@github-actions github-actions bot added the no push access Maintainers cannot push to this pull request. label Jul 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested creation of a replacement PR.

@github-actions github-actions bot dismissed carlocab’s stale review July 22, 2025 19:53

Replacement PR dispatched

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Replacement PR creation failed.

@ReenigneArcher
Copy link
Contributor Author

I allowed access

@carlocab
Copy link
Member

Could it be due to caching?

No, it's a race condition in upstream's install target.

@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions GitHub Actions
Copy link
Contributor

⚠️ Bottle publish failed.

@github-actions GitHub Actions
Copy link
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 22, 2025
@BrewTestBot BrewTestBot enabled auto-merge July 22, 2025 21:36
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 22, 2025
Merged via the queue into Homebrew:main with commit 2778f2f Jul 22, 2025
19 checks passed
@ReenigneArcher ReenigneArcher deleted the add/libdbusmenu branch July 22, 2025 21:55
@ReenigneArcher ReenigneArcher mentioned this pull request Jul 23, 2025
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core no push access Maintainers cannot push to this pull request. perl Perl use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ReenigneArcher @carlocab @BrewTestBot