Skip to content

fx-upscale 1.2.5 (new formula) #229835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025
Merged

fx-upscale 1.2.5 (new formula) #229835

merged 2 commits into from
Jul 29, 2025

Conversation

bevanjkay
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core swift Swift use is a significant feature of the PR or issue macos-only Formula depends on macOS labels Jul 12, 2025
@bevanjkay bevanjkay force-pushed the fx-upscale branch 4 times, most recently from e8b71d8 to 73adfb8 Compare July 12, 2025 01:46
@bevanjkay
Copy link
Member Author

I wonder if CI is running out of memory?

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 12, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 12, 2025
@bevanjkay bevanjkay force-pushed the fx-upscale branch 2 times, most recently from 882272e to 057a108 Compare July 16, 2025 03:52
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 16, 2025
@bevanjkay bevanjkay force-pushed the fx-upscale branch 2 times, most recently from 07d3f1b to 8a1cd7f Compare July 16, 2025 04:35
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 16, 2025
@bevanjkay bevanjkay force-pushed the fx-upscale branch 3 times, most recently from 880d9a1 to 5c436f0 Compare July 16, 2025 05:13
@bevanjkay bevanjkay force-pushed the fx-upscale branch 2 times, most recently from dba3689 to 8256b62 Compare July 16, 2025 23:17
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Would be nice to start replacing the .mp4 fixtures we have with the built-in one now too.

@bevanjkay
Copy link
Member Author

Unfortunately I think it's still failing. I don't have an intel box on hand at the moment to test it locally, but I can look into it next week.

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jul 29, 2025
fx-upscale: update to use h264 codec

Co-authored-by: Rui Chen <rui@chenrui.dev>
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just merge as-is, TBH. Missing Intel bottles don't seem so bad.

@chenrui333
Copy link
Member

We should just merge as-is, TBH. Missing Intel bottles don't seem so bad.

I think we probably should ignore the intel tests (I have run them as it works for me as well)

@carlocab
Copy link
Member

Let's merge this as-is for now.

Copy link
Contributor

:shipit: @carlocab has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 29, 2025
@BrewTestBot BrewTestBot enabled auto-merge July 29, 2025 13:56
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 29, 2025
Merged via the queue into main with commit 22b0fa3 Jul 29, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the fx-upscale branch July 29, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. macos-only Formula depends on macOS new formula PR adds a new formula to Homebrew/homebrew-core swift Swift use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants