-
-
Notifications
You must be signed in to change notification settings - Fork 13k
fx-upscale 1.2.5 (new formula) #229835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fx-upscale 1.2.5 (new formula) #229835
Conversation
e8b71d8
to
73adfb8
Compare
I wonder if CI is running out of memory? |
882272e
to
057a108
Compare
07d3f1b
to
8a1cd7f
Compare
880d9a1
to
5c436f0
Compare
dba3689
to
8256b62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Would be nice to start replacing the .mp4
fixtures we have with the built-in one now too.
Unfortunately I think it's still failing. I don't have an intel box on hand at the moment to test it locally, but I can look into it next week. |
fx-upscale: update to use h264 codec Co-authored-by: Rui Chen <rui@chenrui.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should just merge as-is, TBH. Missing Intel bottles don't seem so bad.
I think we probably should ignore the intel tests (I have run them as it works for me as well) |
Let's merge this as-is for now. |
Caution Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?