Skip to content

amdatu-bootstrap: Update link #22609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2018
Merged

amdatu-bootstrap: Update link #22609

merged 2 commits into from
Jan 9, 2018

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Jan 9, 2018 •
edited
Loading

The user managing this repository on BitBucket changed their username. This should fix it right up!

OLD DESCRIPTION: These are updates to fix some of the broken links as listed in #22653. I have not gotten the chance to test these out with a brew install and brew audit -- I'm in the middle of an update of my formulas -- but will make changes as needed and as specified by the Brew Test Bot!

@queengooborg queengooborg mentioned this pull request Jan 9, 2018
Closed
28 tasks
@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 9, 2018

Thanks @vinyldarkscratch! Note that checksum changes must be reported to and confirmed by upstream before we update them to rule out malicious circumstances. So those should be in individual PRs so they don't block the rest.

@queengooborg
Copy link
Contributor Author

That makes complete sense! I shall cherrypick those commits now. 🙂

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 9, 2018

for cadaver we can use a mirror. there are a few if you google the tarball name

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 9, 2018

The ones for formula version upgrades should also be in separate PRs since they'll need new bottles pulled whereas the ones where we're just updating the URL won't.

@queengooborg
Copy link
Contributor Author

Alrighty, allow me to cherrypick the rest of the changes (probably should have done that already, #LazyDev) -- standby, and thank you!

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 9, 2018

hehe no worries. We really appreciate the help with these.

@queengooborg queengooborg changed the title amdatu-bootstrap, cadaver, entr, daq, fdclone, jhiccup & xshogi: updates amdatu-bootstrap: Update link Jan 9, 2018
@queengooborg
Copy link
Contributor Author

queengooborg commented Jan 9, 2018 •
edited
Loading

The Brew Test Bot is reporting (on a few of my PRs):

01:09:38 Homebrew Core Pull Requests » sierra completed with result FAILURE
01:09:38 Homebrew Core Pull Requests » el_capitan completed with result FAILURE
01:12:55 Homebrew Core Pull Requests » high_sierra completed with result FAILURE

I feel a little embarrassed for asking, @ilovezfs, but is there a way to request the test bot to re-test something?

@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 9, 2018

That looks like a Java 9 failure.

@ilovezfs ilovezfs added the java Java use is a significant feature of the PR or issue label Jan 9, 2018
@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 9, 2018 

diff --git a/Formula/amdatu-bootstrap.rb b/Formula/amdatu-bootstrap.rb
index 9c0e479..a2538e3 100644
--- a/Formula/amdatu-bootstrap.rb
+++ b/Formula/amdatu-bootstrap.rb
@@ -6,9 +6,11 @@ class AmdatuBootstrap < Formula
 
   bottle :unneeded
 
+  depends_on :java => "1.8"
+
   def install
     libexec.install %w[amdatu-bootstrap bootstrap.jar conf]
-    bin.install_symlink "#{libexec}/amdatu-bootstrap" => "amdatu-bootstrap"
+    (bin/"amdatu-bootstrap").write_env_script libexec/"amdatu-bootstrap", Language::Java.java_home_env("1.8")
   end
 
   test do

@queengooborg
Copy link
Contributor Author

Oh I'm stupid, I was looking at the wrong part -- I was looking at the Console Output (like on Travis CI), not the Test Results. Durr! 🤦‍♀️

@ilovezfs ilovezfs merged commit e03a339 into Homebrew:master Jan 9, 2018
@ilovezfs
Copy link
Contributor

ilovezfs commented Jan 9, 2018

Thanks @vinyldarkscratch! 👢

@queengooborg queengooborg deleted the fixes-for-22563 branch January 9, 2018 10:13
@ilovezfs ilovezfs mentioned this pull request Jan 9, 2018
Closed
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ilovezfs ilovezfs ilovezfs approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
java Java use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @ilovezfs