Tweak GitHub Actions workflows #226572
Merged
Tweak GitHub Actions workflows #226572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prepare to use `main` instead of `master`. - use synced `actionlint.yml` to simplify Homebrew/.github sync logic.
p-linnane
approved these changes
Jun 11, 2025
carlocab
reviewed
Jun 12, 2025
Comment on lines
-67
to
-69
| # Setting `shell: /bin/bash` prevents shellcheck from running on | ||
| # those steps, so let's change them to `shell: bash` for linting. | ||
| sed -i 's|shell: /bin/bash -x|shell: bash -x|' .github/workflows/*.y*ml |
There was a problem hiding this comment.
Getting rid of this will stop shellcheck from working on multiple workflows here.
There was a problem hiding this comment.
@carlocab Apologies, see Homebrew/.github#311.
I'm a bit confused as to whether it is/why actionlint isn't being handled by brew style in tap_syntax though?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maininstead ofmaster.actionlint.ymlto simplify Homebrew/.github sync logic.