singular: add flint dep
#222142
Merged
singular: add flint dep
#222142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
150acb4 to
c41e08c
Compare
c41e08c to
0a0c5be
Compare
5 tasks
|
list of dependencies must be sorted in alphabetical order, can you run |
|
done. By the way, |
|
You need to squash your commits 😅 |
|
I thought it's what "autosquash" is for... |
Singular has an optional interface for flint, which is not built in the current formula as it's missing. We add the dependency to let it build it. Basically, it makes the executable a bit bigger and links it (onb my machine, currently) to /usr/local/opt/flint/lib/libflint.20.0.dylib
37b9b2e to
5a8e965
Compare
daeho-ro
approved these changes
May 2, 2025
|
🤖 An automated task has requested bottles to be published to this PR. Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 4, 2025
sagemathgh-40033: Singular 4.4.1 + Flint 3.3.2 Update flint and singular. This will catch up with Conda and Homebrew, possibly other distros (Homebrew needs Homebrew/homebrew-core#222142 merged) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39943: - just not to build patch from source (if you have systemwide patch 2.8) sagemath#39977: - patches to allow gcc-15, etc URL: sagemath#40033 Reported by: Dima Pasechnik Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 5, 2025
sagemathgh-40033: Singular 4.4.1 + Flint 3.3.2 Update flint and singular. This will catch up with Conda and Homebrew, possibly other distros (Homebrew needs Homebrew/homebrew-core#222142 merged) EDIT Homebrew/homebrew-core#222142 has been merged, so now you can install singular from Homebrew and use it! ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39943: - just not to build patch from source (if you have systemwide patch 2.8) sagemath#39977: - patches to allow gcc-15, etc URL: sagemath#40033 Reported by: Dima Pasechnik Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 6, 2025
sagemathgh-40033: Singular 4.4.1 + Flint 3.3.2 Update flint and singular. This will catch up with Conda and Homebrew, possibly other distros (Homebrew needs Homebrew/homebrew-core#222142 merged) EDIT Homebrew/homebrew-core#222142 has been merged, so now you can install singular from Homebrew and use it! ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39943: - just not to build patch from source (if you have systemwide patch 2.8) sagemath#39977: - patches to allow gcc-15, etc URL: sagemath#40033 Reported by: Dima Pasechnik Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 9, 2025
sagemathgh-40033: Singular 4.4.1 + Flint 3.3.2 Update flint and singular. This will catch up with Conda and Homebrew, possibly other distros (Homebrew needs Homebrew/homebrew-core#222142 merged) EDIT Homebrew/homebrew-core#222142 has been merged, so now you can install singular from Homebrew and use it! ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#39943: - just not to build patch from source (if you have systemwide patch 2.8) sagemath#39977: - patches to allow gcc-15, etc URL: sagemath#40033 Reported by: Dima Pasechnik Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?