Skip to content

payara 4.1.2.174 #21286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2017
Merged

payara 4.1.2.174 #21286

merged 2 commits into from
Dec 3, 2017

Conversation

dpoggi
Copy link
Contributor

@dpoggi dpoggi commented Dec 3, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@dpoggi
Copy link
Contributor Author

dpoggi commented Dec 3, 2017

Looks like CI is trying to run the tests with Java 9, which will definitely fail every time (Payara 4.x will never be compatible AFAIK). I'm not familiar, is there any way to signal compatibility with specifically Java 7 and 8?

@ilovezfs ilovezfs added build failure CI fails while building the software java Java use is a significant feature of the PR or issue test failure CI fails while running the test-do block and removed build failure CI fails while building the software labels Dec 3, 2017
@ilovezfs ilovezfs merged commit 048cdd3 into Homebrew:master Dec 3, 2017
@ilovezfs ilovezfs removed the test failure CI fails while running the test-do block label Dec 3, 2017
@ilovezfs
Copy link
Contributor

ilovezfs commented Dec 3, 2017

Thanks @dpoggi! Shipped with Java 8 wrapper script.

@ilovezfs ilovezfs mentioned this pull request Dec 3, 2017
Closed
@dpoggi dpoggi deleted the payara-4.1.2.174 branch December 6, 2017 21:52
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
java Java use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpoggi @ilovezfs