Skip to content

kubefirst: test fix #207518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

kubefirst: test fix #207518

merged 1 commit into from
Feb 13, 2025

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Feb 13, 2025 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Adjusted for

where they started to send version to ErrOrStderr out: https://github.com/konstructio/kubefirst/pull/2406/files#diff-7cb26babce207ed9c17e9dd3ead0b66d204da3cf4d11649412c197defbb3029cR21

But due to timing it started to fail in

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Feb 13, 2025
@stefanb stefanb mentioned this pull request Feb 13, 2025
Merged
39 tasks
@stefanb stefanb added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Feb 13, 2025
@stefanb stefanb force-pushed the kubefirst-revision-bump-go-1.24 branch from ade9599 to f087da0 Compare February 13, 2025 20:46
@stefanb stefanb force-pushed the kubefirst-revision-bump-go-1.24 branch from f087da0 to d1b8980 Compare February 13, 2025 21:01
@stefanb stefanb changed the title kubefirst: revision bump (go 1.24) kubefirst: test fix Feb 13, 2025
@stefanb stefanb added the CI-no-bottles Merge without publishing bottles label Feb 13, 2025
@stefanb stefanb marked this pull request as ready for review February 13, 2025 21:15
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 13, 2025
Merged via the queue into master with commit ef2becd Feb 13, 2025
23 checks passed
@BrewTestBot BrewTestBot deleted the kubefirst-revision-bump-go-1.24 branch February 13, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-linnane p-linnane p-linnane approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. go Go use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanb @p-linnane @BrewTestBot