Skip to content

duck 6.2.10 #19938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

duck 6.2.10 #19938

wants to merge 4 commits into from

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented Oct 27, 2017

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@ilovezfs ilovezfs added the java Java use is a significant feature of the PR or issue label Oct 27, 2017
@ilovezfs
Copy link
Contributor

@dkocher this is failing due to incompatibility with Java 9.

@ilovezfs ilovezfs mentioned this pull request Oct 27, 2017
Closed
@ilovezfs
Copy link
Contributor

@dkocher also, with Java 8, the test block fails:

==> Summary
🍺  /usr/local/Cellar/duck/6.2.10.26754: 839 files, 168.9MB, built in 11 minutes 25 seconds
iMac-TMP:~ joe$ brew test -vd duck
/usr/local/Homebrew/Library/Homebrew/brew.rb (Formulary::FormulaLoader): loading /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/duck.rb
Testing duck
/usr/bin/sandbox-exec -f /tmp/homebrew20171027-60103-ozjzxj.sb /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/bin/ruby -W0 -I /usr/local/Homebrew/Library/Homebrew -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/duck.rb -vd
/usr/local/Homebrew/Library/Homebrew/test.rb (Formulary::FromPathLoader): loading /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/duck.rb
/usr/local/Homebrew/Library/Homebrew/test.rb (Formulary::FormulaLoader): loading /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/libmagic.rb
==> /usr/local/Cellar/duck/6.2.10.26754/bin/duck --download ftp://ftp.astron.com/pub/file/file-5.32.tar.gz /tmp/duck-test-20171027-60104-g8i7i8/test
Picked up _JAVA_OPTIONS:  -Duser.home=/Users/joe/Library/Caches/Homebrew/java_cache
Missing protocol in URI ftp://ftp.astron.com/pub/file/file-5.32.tar.gz
Try 'duck --help' for more options.

/usr/local/Homebrew/Library/Homebrew/test.rb (Formulary::FormulaLoader): loading /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/python.rb
/usr/local/Homebrew/Library/Homebrew/debrew.rb:11:in `raise'
BuildError: Failed executing: /usr/local/Cellar/duck/6.2.10.26754/bin/duck --download ftp://ftp.astron.com/pub/file/file-5.32.tar.gz /tmp/duck-test-20171027-60104-g8i7i8/test

@dkocher
Revert test.
063886b 
Opening FTP connection to ftp.astron.com…
Connection timed out. Connect timed out. The connection attempt timed out. The server may be down, or your network may not be properly configured.
@dkocher
Require Java 8
257fdb5 
Compile with Java 9 is not currently supported.
@ilovezfs
Copy link
Contributor

Requiring Java 8 currently means this cannot be bottled.

@dkocher
Copy link
Contributor Author

dkocher commented Oct 27, 2017

We will have to wait for the next release then which can fix the build issue with Java 9.

@ilovezfs
Copy link
Contributor

@dkocher a fix cannot be applied as a patch?

@dkocher
Copy link
Contributor Author

dkocher commented Oct 27, 2017

You could apply iterate-ch/cyberduck@612a973

@ilovezfs
Copy link
Contributor

@dkocher done!

@ilovezfs
Copy link
Contributor

Thanks again, @dkocher! Shipped. 🦆

@ilovezfs ilovezfs closed this in c4a0c73 Oct 28, 2017
robohack pushed a commit to robohack/homebrew-core that referenced this pull request Nov 3, 2017
@ilovezfs
duck: backport Java 9 compatibility fix
501ea47 
Closes Homebrew#19938.

Signed-off-by: ilovezfs <ilovezfs@icloud.com>
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
java Java use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkocher @ilovezfs @cyberduck