Skip to content

jupyterlab: add ninja build dep for ipykernel #199609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2024
Merged

jupyterlab: add ninja build dep for ipykernel #199609

merged 1 commit into from
Dec 1, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?
        LookupError: https://files.pythonhosted.org/packages/b4/49/4f1a79f99f4c3eb5d22f943bba14832923bb44423254d5089d38a9f6da63/ninja-1.11.1.2.tar.gz (from https://pypi.org/simple/ninja/) (requires-python:>=3.7) is already being built: ninja>=1.5 from https://files.pythonhosted.org/packages/b4/49/4f1a79f99f4c3eb5d22f943bba14832923bb44423254d5089d38a9f6da63/ninja-1.11.1.2.tar.gz
        error: subprocess-exited-with-error

@chenrui333
jupyterlab: add ninja build dep for ipykernel
3e4da00 
Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 added rust Rust use is a significant feature of the PR or issue CI-no-bottles Merge without publishing bottles labels Nov 30, 2024
@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue labels Nov 30, 2024
@chenrui333 chenrui333 mentioned this pull request Nov 30, 2024
Merged
1 task
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 1, 2024
Merged via the queue into master with commit 7599378 Dec 1, 2024
27 checks passed
@BrewTestBot BrewTestBot deleted the jupyterlab-update-build branch December 1, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daeho-ro daeho-ro daeho-ro approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles nodejs Node or npm use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenrui333 @daeho-ro @BrewTestBot