Skip to content

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

relates to #157782

@chenrui333 chenrui333 changed the title go@1.20 deprecate go@1.20: deprecate Feb 14, 2024
@github-actions github-actions bot added go Go use is a significant feature of the PR or issue formula deprecated Formula deprecated labels Feb 14, 2024
@stefanb
Copy link
Member

stefanb commented Feb 14, 2024

Shouldn't also the whole livecheck block be removed? Like in my draft (based on previous deprecations): master...stefanb:homebrew-core:go-1.20-deprecate ?

@chenrui333
Copy link
Member Author

Shouldn't also the whole livecheck block be removed? Like in my draft (based on previous deprecations): master...stefanb:homebrew-core:go-1.20-deprecate ?

Good catch, removing the livecheck block.

Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 14, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 14, 2024
Merged via the queue into Homebrew:master with commit d843c83 Feb 14, 2024
@chenrui333 chenrui333 deleted the go-1.20-deprecate branch February 14, 2024 13:17
@stefanb stefanb mentioned this pull request Feb 14, 2024
6 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 16, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. formula deprecated Formula deprecated go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants