Skip to content

imposm3: fix osmium path in test #158863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2024
Merged

imposm3: fix osmium path in test #158863

merged 1 commit into from
Jan 3, 2024

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Jan 3, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

osmium is not installed by the imposm3 formula, hence the bin directory in the test doesn't contain osmium. This is one of the failures spotted in #158685.

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Jan 3, 2024
@branchvincent branchvincent added the CI-no-bottles Merge without publishing bottles label Jan 3, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 3, 2024
Merged via the queue into Homebrew:master with commit 3c72570 Jan 3, 2024
@Moisan Moisan deleted the imposm3_test branch January 3, 2024 20:31
@stefanb stefanb mentioned this pull request Jan 14, 2024
Merged
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@branchvincent branchvincent branchvincent approved these changes

Assignees
No one assigned
Labels
CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moisan @branchvincent @BrewTestBot