Skip to content

go-critic 0.9.0 #139183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 10, 2023
Merged

go-critic 0.9.0 #139183

merged 2 commits into from
Aug 10, 2023

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Aug 10, 2023 •
edited
Loading

https://github.com/go-critic/go-critic/releases/tag/v0.9.0

Compatible with Go 1.21: #134468

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Aug 10, 2023
@stefanb stefanb mentioned this pull request Aug 10, 2023
Merged
89 tasks
@github-actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Aug 10, 2023
@BrewTestBot BrewTestBot enabled auto-merge August 10, 2023 11:52
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 10, 2023
Merged via the queue into Homebrew:master with commit 8682b2e Aug 10, 2023
@stefanb stefanb deleted the bump-go-critic-0.9.0 branch August 10, 2023 12:06
@chenrui333
Copy link
Member

chenrui333 commented Aug 10, 2023 •
edited
Loading

test needs update after go1.21 upgrade

  /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/bin/bundle clean
  ==> Testing go-critic
  ==> /home/linuxbrew/.linuxbrew/Cellar/go-critic/0.9.0/bin/gocritic check main.go 2>&1
  panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
  
  goroutine 1 [running]:
  main.main()
  	github.com/go-critic/go-critic/cmd/gocritic/main.go:16 +0x52
  ==> Testing go-critic (again)
  ==> /home/linuxbrew/.linuxbrew/Cellar/go-critic/0.9.0/bin/gocritic check main.go 2>&1
  panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt
  
  goroutine 1 [running]:
  main.main()
  	github.com/go-critic/go-critic/cmd/gocritic/main.go:16 +0x52
  Error: go-critic: failed
  An exception occurred within a child process:
    Minitest::Assertion: Expected: 1
    Actual: 2

@stefanb
Copy link
Member Author

stefanb commented Aug 11, 2023 •
edited
Loading

@chenrui333 could this be fixed just by formula revision bump in #134468, to make sure it is rebuilt with Go 1.21?

@stefanb stefanb mentioned this pull request Aug 11, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanb @chenrui333 @BrewTestBot