Skip to content

algernon: add build patch for go1.21 #137320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

algernon: add build patch for go1.21 #137320

wants to merge 1 commit into from

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Jul 22, 2023 •
edited
Loading

Add support for Go 1.20 and 1.21 via patch from

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue autosquash Automatically squash pull request commits according to Homebrew style. labels Jul 22, 2023
stefanb
stefanb commented Jul 22, 2023
View reviewed changes
@stefanb stefanb mentioned this pull request Jul 22, 2023
Merged
89 tasks
@stefanb @chenrui333
algernon: add build patch for go1.21
444a67e 
algernon 1.15.2 (build with go 1.21)

fix formula syntax

algernon: update patch

Signed-off-by: Rui Chen <rui@chenrui.dev>
@chenrui333 chenrui333 changed the title algernon 1.15.2 (buildable with go 1.21) algernon: add build patch for go1.21 Aug 9, 2023
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Aug 9, 2023
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Aug 9, 2023
@stefanb
Copy link
Member Author

stefanb commented Aug 10, 2023 •
edited
Loading

Note, that @xyproto added many other related commits recently to algernon, but not released yet.

@xyproto
Copy link
Contributor

xyproto commented Aug 10, 2023

Algernon 1.15.3 with support for both Go 1.21 and QUIC+macOS M1/M2/aarch64 is out:

https://github.com/xyproto/algernon/releases/tag/v1.15.3

@stefanb
Copy link
Member Author

stefanb commented Aug 10, 2023

Tnx will create a new PR.

@stefanb stefanb closed this Aug 10, 2023
@stefanb stefanb mentioned this pull request Aug 10, 2023
Merged
6 tasks
@stefanb stefanb deleted the algernon-go1.21 branch August 10, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

Assignees
No one assigned
Labels
go Go use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanb @xyproto @chenrui333