irssi 1.4.4 #136747
Merged
irssi 1.4.4 #136747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <rui@chenrui.dev> irssi: update build and test Signed-off-by: Rui Chen <rui@chenrui.dev> irssi: remove head build Signed-off-by: Rui Chen <rui@chenrui.dev>
This was referenced Jul 16, 2023
Closed
Closed
Closed
Closed
Closed
chenrui333
commented
Jul 16, 2023
Formula/irssi.rb
Outdated
Comment on lines
26
to
32
| head do | ||
| url "https://github.com/irssi/irssi.git", branch: "master" | ||
| depends_on "autoconf" => :build | ||
| depends_on "automake" => :build | ||
| depends_on "libtool" => :build | ||
| depends_on "lynx" => :build | ||
| end |
There was a problem hiding this comment.
we can re-add the HEAD build when we fix the meson build
chenrui333
commented
Jul 16, 2023
Comment on lines
-79
to
-85
| # This is not how you'd use Perl with Irssi but it is enough to be | ||
| # sure the Perl element didn't fail to compile, which is needed | ||
| # because upstream treats Perl build failures as non-fatal. | ||
| # To debug a Perl problem copy the following test at the end of the install | ||
| # block to surface the relevant information from the build warnings. | ||
| ENV["PERL5LIB"] = lib/"perl5/site_perl" | ||
| system "perl", "-e", "use Irssi" |
There was a problem hiding this comment.
I dont feel this is useful, so removing it for now to unblock the release build
carlocab
reviewed
Jul 17, 2023
| @@ -49,39 +37,21 @@ def install | |||
| --with-proxy | |||
| --enable-true-color | |||
| --with-socks=no | |||
| --with-perl=yes | |||
| --with-perl-lib=#{lib}/perl5/site_perl | |||
| --with-perl=no | |||
There was a problem hiding this comment.
Is building the Perl module broken?
There was a problem hiding this comment.
once the meson build issue is fixed, we can try meson build to see it helps. (the master build is already with meson)
fxcoudert
approved these changes
Jul 17, 2023
|
🤖 An automated task has requested bottles to be published to this PR. |
|
This pretty much removes irssi's ability to load in scripts... which alot of people use. |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?