-
-
Notifications
You must be signed in to change notification settings - Fork 13k
leveldb: Disable tcmalloc #88758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
leveldb: Disable tcmalloc #88758
Conversation
This should fix google/leveldb#634
It seems weird to do this, since I expect macOS to not be affected by the issue you're referencing. I was going to try it for myself, but we already see from google/leveldb#634 (comment):
|
Yes, This only seems to happen in Monterey. |
No, I don't think that's true.
|
Where I see this is here: https://gitlab.haskell.org/ghc/ghc/-/issues/20610 I wonder if that might be a different linker issue as it does successfully link and then crash. |
It seems like your bug is something else entirely, as the reproducer in the issue you reference doesn't apply. I'm reluctant to apply a change to a formula that affects many other users when it's not at all clear that this is the right fix. Moreover, even if it were the right one, I don't know how this weighs against potentially breaking other users who rely on I don't use GHC, so I can't really say what's happening with your crash. Does GHC call |
Yes, GHC does call |
I see. But it seems the |
Does this fix your issue? gperftools/gperftools#1315 |
Simple programs segfault when linked with tcmalloc. Patch taken from gperftools/gperftools#1315. Also, update the test to catch the segfault. Closes Homebrew#88758.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?This adresses google/leveldb#634.
When installing this locally I had to remove
gperftools
first for this to work. I don't know how the bottles are built and if that will be ensured.