nlohmann-json 3.10.0 #83479
Closed
nlohmann-json 3.10.0 #83479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
carlocab
reviewed
Aug 18, 2021
There was a problem hiding this comment.
Thanks, @amirmasoudabdol.
For future reference, please adhere to the commit style guide referenced in the PR template when writing commit messages:
The preferred commit message format for simple version updates is
foobar 7.3and for fixes isfoobar: fix flibble matrix..
Formula/nlohmann-json.rb
Outdated
| }} | ||
| }; | ||
| std::cout << j << std::endl; |
There was a problem hiding this comment.
Let's keep something like this in the test so we have output to check, please.
There was a problem hiding this comment.
Sure. I think I will bring back the old test. I realised that it's a better test for the Homebrew.
carlocab
approved these changes
Aug 18, 2021
amirmasoudabdol
added a commit
to amirmasoudabdol/json
that referenced
this pull request
Aug 18, 2021
I've submitted a PR on [homebrew/core](Homebrew/homebrew-core#83479) that updates their Formula. After that one is set, we can merge this and let users use the default formula, and we don't have to maintain two separate Formulas.
|
🤖 A scheduled task has triggered a merge. |
|
Thanks a lot for taking care of this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This updates the
nlohmann-jsonformula, and replaces its test with the test provided by @nlohmann. It defaults to build with CMake, and multiple headers.