Skip to content

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Jun 26, 2021

Created with brew bump-formula-pr.


First actual release (not pre-release).
Also try to bottle and probably remove from #80003

@BrewTestBot BrewTestBot added bottle unneeded [DEPRECATED] Bottle does not need to be built bump-formula-pr PR was created using `brew bump-formula-pr` java Java use is a significant feature of the PR or issue labels Jun 26, 2021
@cho-m cho-m added bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. labels Jun 26, 2021
@cho-m cho-m force-pushed the bump-polynote-0.4.2 branch from 2314735 to 99d6a89 Compare June 26, 2021 19:12
@BrewTestBot BrewTestBot removed the bottle unneeded [DEPRECATED] Bottle does not need to be built label Jun 26, 2021
@cho-m cho-m mentioned this pull request Jun 26, 2021
@carlocab
Copy link
Member

carlocab commented Jun 26, 2021

==> /opt/homebrew/Cellar/polynote/0.4.2/bin/polynote version 2>&1
/opt/homebrew/Cellar/polynote/0.4.2/bin/polynote: line 2: /opt/homebrew/Cellar/polynote/0.4.2/libexec/polynote.jar: No such file or directory
/opt/homebrew/Cellar/polynote/0.4.2/bin/polynote: line 2: exec: /opt/homebrew/Cellar/polynote/0.4.2/libexec/polynote.jar: cannot execute: No such file or directory

There doesn't appear to be a libexec/"polynote.jar" anymore. I think they now ship a polynote.py wrapper script to call java.

I think this script has a dependency on https://pypi.org/project/jep/.

In fact, the tarball has a requirements.txt containing

virtualenv
ipython
nbconvert
numpy
pandas
jedi==0.18.*
jep==3.9.*

@carlocab carlocab added the test failure CI fails while running the test-do block label Jun 26, 2021
@cho-m cho-m force-pushed the bump-polynote-0.4.2 branch from 99d6a89 to 3f1c95b Compare June 26, 2021 20:59
@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Jun 26, 2021
@cho-m cho-m removed the test failure CI fails while running the test-do block label Jun 26, 2021
@cho-m
Copy link
Member Author

cho-m commented Jun 26, 2021

As far as I can tell, only jep is a required Python dependency.

Most of others are never directly used.


numpy is one that I am not sure of.

polynote only uses numpy in an example Jupyter notebook: examples/Plotting Scala data with Matplotlib.ipynb

However, jep has an optional numpy dependency, which is detected at build-time and enables features.
Since I am not sure, I am including it just in case.


pandas is the only other requirement that occurs outside requirements.txt and it is used in another Jupyter notebook: examples/Scala Spark to Pandas.ipynb.

That is the one that caused issues in previous update attempt: #74313 (comment), so will avoid.

@cho-m cho-m added the ready to merge PR can be merged once CI is green label Jun 26, 2021
@cho-m cho-m mentioned this pull request Jun 27, 2021
14 tasks
Comment on lines +32 to +33
env = Language::Java.overridable_java_home_env
env["PYTHONPATH"] = ENV["PYTHONPATH"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try avoiding env, since I think the Formula class (or something else it includes) defines an env method.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2021
@cho-m cho-m deleted the bump-polynote-0.4.2 branch April 24, 2022 21:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled bump-formula-pr PR was created using `brew bump-formula-pr` CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. java Java use is a significant feature of the PR or issue outdated PR was locked due to age python Python use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants