gwt: remove bottle :unneeded. #80145
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It obviously misses |
|
@yurikoles Yes. It also requires updating all the scripts so they can find JAVA_HOME. |
cho-m
commented
Jun 27, 2021
Comment on lines
-27
to
-31
| (bin/"benchmarkViewer").write <<~EOS | ||
| #!/bin/sh | ||
| APPDIR=#{libexec} | ||
| java -Dcom.google.gwt.junit.reportPath="$1" -cp "$APPDIR/gwt-dev.jar" com.google.gwt.dev.RunWebApp -port auto $APPDIR/gwt-benchmark-viewer.war; | ||
| EOS |
There was a problem hiding this comment.
Not sure if this still exists: #{libexec}/gwt-benchmark-viewer.war
❯ benchmarkViewer
Could not open war file '/usr/local/Cellar/gwt/2.9.0/libexec/gwt-benchmark-viewer.war'
Google Web Toolkit 2.9.0
❯ fd -IHe war
❯ fd -IHe jar
gwt-api-checker.jar
gwt-codeserver.jar
...
❯ fd benchmark
❯ fd i18nCreator
i18nCreator
i18nCreator.cmd
❯ fd webAppCreator
webAppCreator
webAppCreator.cmd|
Checksums all match: Just need review on script changes and should be good to merge. |
carlocab
approved these changes
Jun 28, 2021
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75943
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Extracted from #79997 to work on separately