Skip to content

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.


previous effort, #58249

@BrewTestBot BrewTestBot added the deprecated license Formula uses a deprecated SPDX license which should be updated label Sep 19, 2020
@chenrui333
Copy link
Member Author

license header ref:

/**
*  This file is part of rmlint.
*
*  rmlint is free software: you can redistribute it and/or modify
*  it under the terms of the GNU General Public License as published by
*  the Free Software Foundation, either version 3 of the License, or
*  (at your option) any later version.
*
*  rmlint is distributed in the hope that it will be useful,
*  but WITHOUT ANY WARRANTY; without even the implied warranty of
*  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
*  GNU General Public License for more details.
*
*  You should have received a copy of the GNU General Public License
*  along with rmlint.  If not, see <http://www.gnu.org/licenses/>.
*
** Authors:
 *
 *  - Christopher <sahib> Pahl 2010-2020 (https://github.com/sahib)
 *  - Daniel <SeeSpotRun> T.   2014-2020 (https://github.com/SeeSpotRun)
 *
** Hosted on http://github.com/sahib/rmlint
*
**/

@BrewTestBot BrewTestBot removed the deprecated license Formula uses a deprecated SPDX license which should be updated label Sep 19, 2020
@chenrui333
Copy link
Member Author

==> Testing rmlint
/usr/bin/sandbox-exec -f /private/tmp/homebrew20200920-76597-xtlr6q.sb ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/test.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/rmlint.rb --verbose
==> /usr/local/Cellar/rmlint/2.10.1/bin/rmlint
Error: rmlint: failed
An exception occurred within a child process:
  Test::Unit::AssertionFailedError: </==>\ 0\ file\(s\)\ after\ investigation,\ nothing\ to\ search\ through\./> was expected to be =~
<"\n" +
"# Duplicate(s):\n" +
"    ls '/private/tmp/rmlint-test-20200920-76598-skq608/1.txt'\n" +
"    rm '/private/tmp/rmlint-test-20200920-76598-skq608/2.txt'\n" +
"\n" +
"==> Note: Please use the saved script below for removal, not the above output.\n" +
"==> In total 3 files, whereof 1 are duplicates in 1 groups.\n" +
"==> This equals 1 B of duplicates which could be removed.\n" +
"==> Scanning took in total 0.442s.\n" +
"\n" +

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Sep 20, 2020
@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Sep 20, 2020
@chenrui333 chenrui333 closed this Sep 20, 2020
@ChrisBaker97
Copy link
Contributor

Hopefully this gets the ball rolling on an upstream fix. I'm not a C programmer, though, so going to need a little help to polish it off.

ChrisBaker97 added a commit to ChrisBaker97/homebrew-core that referenced this pull request Nov 12, 2020
* bump version to 2.10.1
* patch lib/cfg.c on Mojave & High Sierra to fix bug introduced in
    rmlint v 2.10.0
* update license

Reference:
* sahib/rmlint#438
* sahib/rmlint#444
* Homebrew#58249
* Homebrew#61404
@ChrisBaker97 ChrisBaker97 mentioned this pull request Nov 12, 2020
5 tasks
BrewTestBot pushed a commit that referenced this pull request Nov 13, 2020
* bump version to 2.10.1
* patch lib/cfg.c on Mojave & High Sierra to fix bug introduced in
    rmlint v 2.10.0
* update license

Reference:
* sahib/rmlint#438
* sahib/rmlint#444
* #58249
* #61404

Closes #64676.

Signed-off-by: Sean Molenaar <1484494+SMillerDev@users.noreply.github.com>
Signed-off-by: BrewTestBot <1589480+BrewTestBot@users.noreply.github.com>
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 13, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 13, 2020
@chenrui333 chenrui333 deleted the rmlint-2.10.1 branch December 18, 2022 05:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age test failure CI fails while running the test-do block upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants