Skip to content

Conversation

liamdawson
Copy link
Contributor

Add the pastel command-line utility, for working with colors

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Found this tool I'm looking forward to integrating in my workflow, would be awesome to have it in brew to make that easier.

https://github.com/sharkdp/pastel

@sharkdp
Copy link

sharkdp commented Aug 26, 2019

Thank you very much for creating this formula. pastel creates shell completion files for bash, zsh and fish during the build. This is not a necessity, but if you want, you could install them in the right places. For reference, here is what the Arch Linux package does: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=pastel (look for SHELL_COMPLETIONS_DIR and install .... completions/... below.

@fxcoudert fxcoudert added the new formula PR adds a new formula to Homebrew/homebrew-core label Aug 26, 2019
@fxcoudert
Copy link
Member

Installing completion files would be nice… look at the use of fish_completion.install, bash_completion.install and zsh_completion.install in other formulas.

@liamdawson
Copy link
Contributor Author

I've added the shell completions now, thanks for the directions!

@agustif
Copy link

agustif commented Aug 29, 2019

I would like to install pastel via brew too

@kenchan0130
Copy link

kenchan0130 commented Aug 30, 2019

I would say it's better to download tar.gz directly than build with Rust and it shouldn't increase unnecessary dependencies.

In this case, you can use https://github.com/sharkdp/pastel/releases/download/v0.5.2/pastel-v0.5.2-x86_64-apple-darwin.tar.gz.

@liamdawson
Copy link
Contributor Author

@kenchan0130 I was mirroring an existing formula for a Rust utility. No runtime dependencies necessary, so if it's bottled, no dependencies needed to install.

@liamdawson
Copy link
Contributor Author

@fxcoudert Any advice on other steps I should take to have this reviewed and hopefully merged? 🙂

@kenchan0130
Copy link

@liamdawson Sounds good.
As an example, I would say it will be like https://github.com/Homebrew/homebrew-core/blob/master/Formula/nodebrew.rb.

@SMillerDev
Copy link
Member

Binary formula are forbidden in homebrew. The nodebrew formula is using the source from a tag rather than a binary distribution.

@4cm4k1
Copy link

4cm4k1 commented Sep 6, 2019

@SMillerDev It looks like the url used by @liamdawson is actually the source from a tag, so is there something else to do? I'm looking forward to installing this package.

@fxcoudert fxcoudert added the almost there PR is nearly ready to merge label Sep 14, 2019
@liamdawson liamdawson changed the title pastel 0.5.2 (new formula) pastel 0.5.3 (new formula) Sep 16, 2019
@liamdawson
Copy link
Contributor Author

I've also bumped the version to 0.5.3, as that's out now, but I can remove that commit if it's better to introduce that version bump separately.

@SMillerDev
Copy link
Member

It's fine, can you squash the commits into one using <formula> <version> (new formula)?

Add the pastel command-line utility, for working with colors
@SMillerDev SMillerDev added ready to merge PR can be merged once CI is green and removed almost there PR is nearly ready to merge labels Sep 16, 2019
@SMillerDev
Copy link
Member

Thanks @liamdawson! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@fxcoudert fxcoudert closed this in 4b598c2 Sep 16, 2019
@lock lock bot added the outdated PR was locked due to age label Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants