Skip to content

alienator88-sentinel 3.0.0 (new cask) #215341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

alienator88-sentinel 3.0.0 (new cask) #215341

merged 1 commit into from
Jun 16, 2025

Conversation

alienator88
Copy link
Contributor

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@alienator88 alienator88 changed the title sentinel 3.0.0 (new cask) sentinel-gk 3.0.0 (new cask) Jun 6, 2025
@daeho-ro
Copy link
Member

daeho-ro commented Jun 9, 2025

can you squash your commits with the message same as the title of this PR?

daeho-ro
daeho-ro approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alienator88 alienator88 mentioned this pull request Jun 11, 2025
Closed
bevanjkay
bevanjkay reviewed Jun 14, 2025
View reviewed changes
@bevanjkay bevanjkay added the awaiting maintainer feedback Issue needs response from a maintainer. label Jun 14, 2025
@alienator88
Copy link
Contributor Author

alienator88 commented Jun 16, 2025 •
edited
Loading

Would the cask file go under A now instead of S with the prefix change since the file needs to match the cask id?
Or would it make more sense to name it "sentinel-alienator88" so it stays in the same folder?

@khipp
Copy link
Member

khipp commented Jun 16, 2025 •
edited
Loading

Would the cask file go under A now instead of S with the prefix change since the file needs to match the cask id? Or would it make more sense to name it "sentinel-alienator88" so it stays in the same folder?

Casks/a/alienator88-sentinel.rb would be the new path, given the added prefix.

@alienator88 alienator88 changed the title sentinel-gk 3.0.0 (new cask) alienator88-sentinel 3.0.0 (new cask) Jun 16, 2025
@alienator88
Copy link
Contributor Author

Casks/a/alienator88-sentinel.rb would be the new path, given the added prefix.

Thank you, all set!

@p-linnane p-linnane removed the awaiting maintainer feedback Issue needs response from a maintainer. label Jun 16, 2025
@p-linnane p-linnane added this pull request to the merge queue Jun 16, 2025
Merged via the queue into Homebrew:master with commit 46ca654 Jun 16, 2025
7 checks passed
@sammarcus sammarcus mentioned this pull request Jul 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bevanjkay bevanjkay bevanjkay left review comments

@khipp khipp khipp approved these changes

@daeho-ro daeho-ro daeho-ro approved these changes

Assignees
No one assigned
Labels
new cask
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alienator88 @daeho-ro @khipp @bevanjkay @BrewTestBot @p-linnane